Using Object Model to Find Groups' Members Produces Frankentable

Question

I modified the code here:

How to get all users From Owners Group in SharePoint 2013 for a subsite

to search for groups named "xxx Members" and their members.

To the code, I added:

function AddGroupNameRowToTable(GroupName)
{   
     $("#myUsersTable").append("<tr>" +
                               "<td colspan=2>" + GroupName + "</td>" +
                               "</tr>"); 
}

and a call to it at the end of function ExecuteOnSuccess:

GroupName = item.get_title();
if (GroupName.indexOf(" Members") >= 0)
      {
          //alert(GroupName); 
          AddGroupNameRowToTable(GroupName);
          GetData(GroupName);

The problem is, I get:

Gardeners Members
Horticulturists Members
Fred     Fred@xxxcom
Jed      Jed@xxxcom
Lucy     Lucy@xxxcom
Ron      Ron@xxxcom
Tilly    Tilly@xxxcom

I want to see this (spacing and dash lines for clarity):

Gardeners Members
-----------------
Fred     Fred@xxxcom
Jed      Jed@xxxcom

Horticulturists Members
-----------------------
Lucy     Lucy@xxxcom
Ron      Ron@xxxcom
Tilly    Tilly@xxxcom

It looks like the functions are executing asynchronously, such that the groups get listed first.

I don't know how to get the results I want. The SP object model and coding style are new to me.

Thanks

Answer 1

The GetData function in your code is async so you need to add the function AddGroupNameRowToTable(GroupName) in its success handler. The sample code snippet is below for reference.

function GetData(groupName){
    $.ajax({
        url: _spPageContextInfo.webAbsoluteUrl + "/_api/web/sitegroups/getbyname('" + groupName +"')/users",
        type: "GET",
        dataType: "json",
        headers: {
            Accept: "application/json;odata=verbose", 
        },
        success: function(data){ 
            AddGroupNameRowToTable(groupName); 
            getUsersFromGroupSuccessHandler(data) 
        },
        error: getUsersFromGroupErrorHandler
    });    
}
function getUsersFromGroupSuccessHandler(data) 
{
    checkUsers = data.d.results.length;
    var Owners = [];

    if (checkUsers == 0){
        alert ("There are no results for this");
    }
    else{
        $.each(data.d.results, function(index, item){
            var OwnerName = item.Title;
            var OwnerEmail= item.Email;

            AddRowToTable(OwnerName,OwnerEmail);

        });
    }
} 

Answer 2

The following code for your reference:

<script src="//code.jquery.com/jquery-3.2.1.min.js" type="text/javascript"></script>
<script type="text/javascript">
$(function () {      
    getGroupsUsers();   
});
function getGroupsUsers(){
    var requestUri = _spPageContextInfo.webAbsoluteUrl + "/_api/web/SiteGroups?$filter=substringof('Members',Title)&$expand=Users";

    $.ajax({
        url: requestUri,
        type: "GET",
        contentType: "application/json;odata=verbose",
         headers: { "Accept": "application/json;odata=verbose"},
        success: function (data) {
            var html="<table >";
            var groups=data.d.results;
            for(var i=0;i<groups.length;i++){
                if(i>0){
                    html+="<tr><td colspan=2 style='border-bottom: dotted 2px black;'></td></tr>";
                }
                html+="<tr><td colspan=2><b>"+groups[i].Title+ "</b></td></tr>";
                var users=groups[i].Users.results;
                for(var j=0;j<users.length;j++){
                    html+="<tr><td>"+users[j].Title+"</td><td>"+users[j].Email+"</td></tr>";
                }           
            }
            html+="</table>";
            $("#groupUsers").html(html);
        },
        error: function (e) {
            //alert("Failed to get details");                
        }
    });
}
</script>
<div id="groupUsers"></div>