SP 2010: JSOM function not working on page load

Question

I am running a function on page load to update list item. Here's my complete code -

jQuery(document).ready(function(){
    updatePageViewCount();
});
function updatePageViewCount() {
    var clContext = new SP.ClientContext.get_current();
    var topicList = clContext.get_web().get_lists().getByTitle('Topics');
    clContext.load(topicList);
    clContext.executeQueryAsync(Function.createDelegate(this, this.onQuerySuccess), Function.createDelegate(this, this.onQueryFail));
}

function onQuerySuccess() {
    var listItemEnum = topicList.getEnumerator();
    while (listItemEnum.moveNext()) {
       var topicListItem = listItemEnum.get_current();
       var url = window.location.href;
       alert(url);
       var topicId = url.split("ID=")[1].split("&")[0];
       alert(topicId);
       if(topicListItem.get_Item('Topic_x0020_ID') == topicId){
           var oldData = topicListItem.get_item('ViewCount');
           var newData = parseInt(oldData) + 1;
           alert(newData);
           topicListItem.set_item('ViewCount', newData);
           topicListItem.update();
           clContext.executeQueryAsync(Function.createDelegate(this, this.onItemUpdated), Function.createDelegate(this, this.onQueryFail));  
      }
   }
 }

 function onItemUpdated() {
       alert('Item has been updated!');
 }

 function onQueryFail(sender, args) {
       alert('Request failed.');
 }

Can anyone help me find a fix for this?

Answer 1

Running your code yields an error: topicList.getEnumerator() is not possible, as topicList is an SP.List and thus, no function getEnumerator is available.

If you incorporate the answer from Venkat Konjeti and additionally modify your topicsList to:

topicList = clContext.get_web().get_lists().getByTitle('Topics').getItems(SP.CamlQuery.createAllItemsQuery());

it should work. At least I'm getting your alert(url)-messages. That is only if the list "Topics" exists and has at least one item.

Answer 2

make the couple of changes as below.

1. Use ExecuteorDelayUntilScriptLoaded to make sure you are executing logic after sp.js file loaded.
2. Your topLists variable make it global as you are using in other function.

Make the corrections as shown below

jQuery(document).ready(function(){
    ExecuteOrDelayUntilScriptLoaded(updatePageViewCount, "sp.js");
});
var topicList
function updatePageViewCount() {
    var clContext = new SP.ClientContext.get_current();
    topicList = clContext.get_web().get_lists().getByTitle('Topics');
    clContext.load(topicList);
    clContext.executeQueryAsync(Function.createDelegate(this, this.onQuerySuccess), Function.createDelegate(this, this.onQueryFail));
}

function onQuerySuccess() {
    //topicList is an object. so try to put some alert like this.
    alert(topicList.Title);
}

Answer 3

This could be because your function is called even before loading SP.js file. Try updating your code by using the Script On Demand method call as :

jQuery(document).ready(function(){

 SP.SOD.executeFunc('sp.js','SP.ClientContext',updatePageViewCount);
});

This way your main function will run only after SP.js load.

Answer 4

It may be possible "SP.js" is not fully loaded when you called your function in document ready function.

Please try below code:

SP.SOD.executeFunc('sp.js', 'SP.ClientContext', updatePageViewCount);

Answer 5

I know it is almost a one year old question, but it might help others too.

If you are using Internet Explorer, and the loaded page URL contains # like in http://sharepoint/_layouts/start.aspx?#/sitepages/home.aspx you should read about MDS (Minimal Download Strategy). This blocks your JavaScript what is not registered with RegisterModuleInit() function.

Here is a good article: https://blogs.technet.microsoft.com/sharepointdevelopersupport/2013/02/08/register-csr-override-on-mds-enabled-sharepoint-2013-site/

Deactivating MDS could also help.