0

I am using sp 2013 onpremise. I have some custom list with a custom column "VolgNummer". This is a text field. When I add a new item on this list this number needs to increase with 1. I enabled "unique enforced values" on this field. When I add an item as administrator everything is working fine. When another normal user try to add an item he gets an exception. It looks like the event receiver below generate an clientNumber which is existing. I translate the exception from dutch to english:

The listitem cannot added or edited because there are double values founded on column : [Volgnummer]

Here is the code I am using. Is there something wrong in my code, or do I need to do it another way?

public override void ItemAdding(SPItemEventProperties properties)
        {
            base.ItemAdding(properties);

            // gets the last 2 characters of the year, for example: 14
            string year = DateTime.Now.Year.ToString().Substring(2, 2);

            SPField field = properties.List.Fields[new Guid(properties.Web.Properties[Constants.VOLGNUMMER])];

            // get the last added item from the list
            SPListItemCollection completedItems = properties.List.GetItems(new SPQuery()
            {
                Query = string.Format("<OrderBy><FieldRef Name='{1}' Ascending='FALSE' /></OrderBy><Where><BeginsWith><FieldRef Name='{1}' /><Value Type='Text'>{0}</Value></BeginsWith></Where>",
                    year, field.InternalName),
                RowLimit = 1
            });

            // this number is for initial (first time) if there are no items existed in the list
            string nextNumber = string.Format("{0}{1}",
                year, "001");

            if (completedItems.Count > 0)
                {
                // last added item volgnummer + 1
                nextNumber = (int.Parse(completedItems[0][field.Id].ToString()) + 1).ToString();
                }
            properties.AfterProperties[field.InternalName] = nextNumber;
        }
0

i presume that its becuase your using the event item adding not added, change it to itemAdded and youll be fine! reason bing, the item doesnt exist at that given time so its picking the older value so your getting duplicate values. Having it on item added would mean that it exist in the list and you can pick the current value and increment accordingly!

    public override void ItemAdded(SPItemEventProperties properties)
    {
        base.ItemAdding(properties);

        // gets the last 2 characters of the year, for example: 14
        string year = DateTime.Now.Year.ToString().Substring(2, 2);

        SPField field = properties.List.Fields[new Guid(properties.Web.Properties[Constants.VOLGNUMMER])];

        // get the last added item from the list
        SPListItemCollection completedItems = properties.List.GetItems(new SPQuery()
        {
            Query = string.Format("<OrderBy><FieldRef Name='{1}' Ascending='FALSE' /></OrderBy><Where><BeginsWith><FieldRef Name='{1}' /><Value Type='Text'>{0}</Value></BeginsWith></Where>",
                year, field.InternalName),
            RowLimit = 1
        });

        // this number is for initial (first time) if there are no items existed in the list
        string nextNumber = string.Format("{0}{1}",
            year, "001");

        if (completedItems.Count > 0)
            {
            // last added item volgnummer + 1
            nextNumber = (int.Parse(completedItems[0][field.Id].ToString()) + 1).ToString();
            }
        completedItems[0][field.Id] = nextNumber;
    }
  • Thanks ali for your fast support. But why it is working with userA OK, and userB not? – Ola Feb 10 '14 at 11:07
  • is the column Volgnummer a unique column? by that i mean unique values only? – Ali Jafer Feb 10 '14 at 13:02
  • yes it is a unique value. – Ola Feb 26 '14 at 13:00

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.