Save conflict when trying to update a listitem

Question

In my SPItemEventReceiver I have two methods one ItemCheckedOut and one ItemUpdated.

In the ItemCheckedOut I update one listitem column.

In the other one I do some other updates to the listitem.

When I implemented this ItemCheckedOut I started receive "Save conflict" when I try to publish the item.

The Itemupdated is not even getting trigged.

public override void ItemCheckedOut(SPItemEventProperties properties)
    {
        SPSecurity.RunWithElevatedPrivileges(delegate
            {
                using (var site = new SPSite(properties.Web.Site.ID))
                {
                    using (var web = site.OpenWeb(properties.Web.ID))
                    {
                        web.AllowUnsafeUpdates = true;
                        var item = properties.ListItem;
                        EventFiringEnabled = false;
                        item[BuiltInFieldId.Approval] = false;
                        item.Update();
                        web.AllowUnsafeUpdates = false;
                    }
                }
            });

How can I solve this issue?

Answer 1

I would say reasons might be due to a combination of facts:

you are actually creating a new instance under "System account" - which could practically mean executing in the context of another user. - Use SystemUpdate instead to avoid Version and other automatic column updates - Consider using Synchronous on the receiver declaration (Elements.xml) to avoid additional concerns regarding order of events.

In general, try consolidating changes on the item to avoid triggering multiple Update events, overall re-enable events firing when done.

Answer 2

Not sure if this would really work but can you try to initialize a new SPListItem rather than just using the properties.listItem itself? it is just to align with your initialization of the SPSite and SPWeb Object maybe you can do something like

SPListItem item = Properties.ListItem.Parent.GetItemByID(properties.ListItem.ID);

and then do the update in that specific item.