PNP JS Taxonomy Term retrieval not giving me back all terms in SharePoint online

Question

I'm currently developing a WebPart for a client using SPFX, React JS and PNP JS where I need to get a full list of Countries from a Countries taxonomy at Tenant level to allow my to populate a dropdown to filter items against, My code is currently returning 18 of the 205 countries and I can't figure out why, for some reason I am getting 2 termSets back to get terms from, both of which return the same 18 terms. Only 1 of the Termstores is actually visible to me.

Here is my code for item retrieval

 export function updateSelections(Set, updateState){
  taxonomy.termStores.getByName(definitions.TermStore).get().then( baseStore => {
    TermStore = baseStore;
    baseStore.getTermSetsByName(Set, definitions.languageCode).get().then( thisTermSets => {
      TermSets[Set] = {};
      thisTermSets.forEach(thisTermSet => {
        updateState(thisTermSet);
        thisTermSet.terms.get().then(setTerms => {
          setTerms.forEach(setTerm => {
            const termGUID = setTerm.Id.replace('/Guid(','').replace(')/','');
            setTerm.Id = termGUID;
            TermSets[Set][termGUID] = setTerm;
          });
        });
      });
    });
  }); 
}

The values being passed in are the Termset name and a function to store terms in state. TermSets is a global variable that stores values for later internal calls to reduce the number of SharePoint API calls made. The function is generic as I'm using it to retrive various different termsets and only the Countries termset seems to be causing me this issue.

Here is an overview of the code without enclosed functions etc.

  taxonomy.termStores.getByName(TAXONOMYREFERENCEID).get().then( baseStore => {
baseStore.getTermSetsByName('Country', definitions.languageCode).get().then( TermSets => {
  TermSets.forEach(TermSet => {
    TermSet.terms.get().then(Terms => {
      Store terms in memory
      });
    });
  });
});

});

Can anyone shed light on where I'm going wrong.

Answer 1

I use this to retrieve all terms of a termset:

  const tbatch = taxonomy.createBatch();
      return taxonomy.termStores.getByName("Taxonomy_InjkMqAvKdUBok59vNz/Mg==").get().then((resp1: ITermStore) => {
        return resp1.getTermGroupById("7bdebaed-a684-4682-a5a6-6c1f1e976641").termSets.get().then((resp2: ITermSet[]) => {
          resp2.forEach((ele: ITermSet) => {
            ele.terms.select('Name', 'Id').inBatch(tbatch).get().then((resp3: ITerm[]) => {
              resp3.forEach((t: ITerm) => {
                let ip1 = {
                  parent: ele['Name'],
                  name: t['Name'],
                  id: t['Id'].replace("/Guid(", "").replace(")/", ""),
                };
                tms.push(ip1);

              });
            });
          });
          tbatch.execute().then(_r => {
            resolve(tms);
          });
        });
      });

With:

interface IPTerm {
  parent?: string;
  id: string;
  name: string;
}

interface ITaxonomyPopulatorState {
  terms: IPTerm[];
}

That works for me. This is a link that may help you: Get all child terms from term group in SharePoint Taxonomy using PnP JS