Got blank page when add custom javascript to my CustomMasterPage

Question

I'm follwing this tutorial to branding master page and totally successful. http://sharepoint.rackspace.com/sharepoint-2013-how-to-change-sharepoint-branding-text-in-the-upper-left-part-of-your-screen But when Im trying to do the same step with custom.js . I've got a blank page. Can you guys help me :). Here's my link to add script :

<SharePoint:ScriptLink language="javascript" name="custom.js" OnDemand="true" runat="server" Localizable="false" />

I've added it right under

<SharePoint:CssRegistration ID="CssRegistration1" name="&lt;% $SPUrl:~sitecollection/style library/custom.css %&gt;" runat="server" after="style.css" />

Answer 1

SharePoint:ScriptLink requires you to use SP.SOP.execute in order to load the script. Like this (reference):

SP.SOD.executeOrDelayUntilScriptLoaded(myfunction, 'sp.js');
function myfunction() {
  // my custom code
  //
  SP.SOD.executeOrDelayUntilScriptLoaded(myfunction2, 'custom.js'); //change
}

SP.SOD.notifyScriptLoadedAndExecuteWaitingJobs("sp.js");

Try using the <script> tag instead to have it always load.

<script type="text/javascript" src="~site/style library/js/custom.js" runat="server" />

http://msdn.microsoft.com/en-us/library/microsoft.sharepoint.webcontrols.scriptlink.ASPX

Answer 2

What is it you're trying to achieve here and why does that tutorial make it so unnecessarily complicated??

If you simply want to add some custom JavaScript or jQuery-enable your site, then simply reference them in the masterpage using tags as already stated.

Then in your custom.js add any functions you want to occur after page load into $(document).ready() function. And define any on demand functions and references outside this.

I stronlgy advise leaving any SOD methods well out of a global js file until you have managed to master a simple alert.

Clear the contents of your custom.js and add the following as a test:

jQuery(document).ready(function()
{
    alert('My custom.js loaded);
});

Once you have that working....slowly add additional functionality.

Answer 3

For a Custom User Action (CUA) you need to reference using a token, I was messing around with using an anonymous public CDN to host my scriptsrc. Couple of odd behaviors, when referenced with a full path it failed with 2 exceptions, most notably when i added a folder path /_layouts/15/xxx..js the CUA started working.

Post about it here: http://blog.sharepointsite.co.uk/2017/11/using-cdn-for-custom-user-actions.html