Take the 2-minute tour ×
SharePoint Stack Exchange is a question and answer site for SharePoint enthusiasts. It's 100% free, no registration required.

While testing my solution I receive an error on Feature activation:

Detected use of SPRequest for previously closed SPWeb object. Please close SPWeb objects when you are done with all objects obtained from them, but not before.

This is the way I'm getting SPWeb:

public override void FeatureActivated(SPFeatureReceiverProperties properties)
{
    using (SPWeb web = properties.Feature.Parent as SPWeb)
    {
        ClassOfMine.doYourStuff(web);
    }
}

What am I doing wrong?

share|improve this question

2 Answers 2

up vote 6 down vote accepted

how about;

warning: your feature needs to be scoped as web for it to work obviously ;)

public override void FeatureActivated(SPFeatureReceiverProperties properties)
{
  // No need to dispose the web istance, as indicated in the "Do not dispose" guidance
  SPWeb web = (SPWeb) properties.Feature.Parent      

  ClassOfMine.doYourStuff(web);

}

not using feature:

if not then use the spcontext to get the root web

SPContext.Current.Site.RootWeb

or - for the current web

SPContext.Current.Web

or - for a specific web url

SPContext.Current.Site.OpenWeb("Website_URL"))

to use above in feature you would need to use the properties:

use the properties to get the site to get the rootWeb

SPSite site = properties.Feature.Parent as SPSite;
using (SPWeb web = site.RootWeb)
{

}

or - for the current web

SPWeb web = properties.Feature.Parent as SPWeb;

or - for a specific web url

SPSite site = properties.Feature.Parent as SPSite;
using (SPWeb web = site.OpenWeb("Website_URL"))
{

}
share|improve this answer
    
SPContext.Current.Site.RootWeb worked for me in a way. Thanks :-) –  Marius Kay Jan 18 '13 at 15:37
    
+1 for the answer, I only edited a little imprecision. Hope you don't mind (as told you on meta, I prefer to improve a valid answer ^_^). See this link for other info blogs.msdn.com/b/rogerla/archive/2009/11/30/… –  SPArchaeologist Jan 18 '13 at 16:06
    
lol no probs ;) –  ali Sharepoint Jan 18 '13 at 16:33
    
Is SPContext available in the event/feature receivers? I thought that the only way to access it was using properties..? –  variable Jul 28 at 4:23
1  
@variable yes your right ;) , didnt spot that myself! I think for the op the solution was the first part, as for the second part iv modified it to explain it better :) –  ali Sharepoint Jul 28 at 7:13

You're doing right. Just the scope of the feature must be web. The "Parent" attribute is always the object of the feature scope.

You're also disposing the object with using.

The only problem with SPContext is that you can't activate the feature from PowerShell as there is no http context.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.