get files from doc library is not working

Question

I just dont understand, I need to move some files from one document library, to a document library in a subsite.

But the filescollection its always zero, but there are files there.

What am I missing?

using (SPSite oSPSite = new SPSite(SourceUrl))
                {
                    using (SPWeb oSPWeb = oSPSite.RootWeb)
                    {
                        #region Get existing website documents
                            SPFolder oFolder = oSPWeb.GetFolder(NameDocLibrary);
                            SPList docLibraryToDelete = oSPWeb.Lists[NameDocLibrary];
                            SPFileCollection collFile = oFolder.Files;

                            List<SPFile> listFiles = new List<SPFile>(collFile.Count);
                            foreach (SPFile oFile in collFile)
                            {
                                listFiles.Add(oFile);
                            }
                            Guid ID = new Guid();

                        #endregion


                        #region Move Document Library
                        using (SPSite oSPSiteArchive = new SPSite(SourceUrl))
                        {
                            using (SPWeb oSPWebArchive = oSPSite.OpenWeb("Archive"))
                            {
                                SPList newDocLibrary =oSPWebArchive.Lists.TryGetList(NameDocLibrary);
                                if (newDocLibrary == null)
                                {
                                    ID = oSPWebArchive.Lists.Add(NameDocLibrary, NameDocLibrary, SPListTemplateType.DocumentLibrary);
                                }
                                else
                                {
                                    ID = oSPWebArchive.Lists[NameDocLibrary].ID;
                                }

                                foreach (SPFile moveFile in listFiles)
                                {
                                    moveFile.MoveTo(oSPWebArchive.Url + "/" + NameDocLibrary + "/" + moveFile.Name, true);
                                }
                                oFolder.Delete();
                                oFolder.Update();
                                docLibraryToDelete.Delete();
                                //docLibraryToDelete.Update();
                            }
                        } 

Answer 1

Try using the full address for the GetFolder function call (http://Server/Site/Library) to make sure it is pulling from the right place. I believe this particular function does not actually error on you, so you might not have successfully pulled the folder at all.

Answer 2

Are the document files at the root of the document library or are they all in subfolders?

If they are all in subfolders, then getting folder object at the root of the document library will return 0 for the number of files, since it does not directly contain any files, only folders. You will have to go into each subfolder by using the SubFolder property of the oFolder object.